chore: upgrade contributte/qa to 0.4 - #126
Merged
Merged
Conversation
Bumps contributte/qa from ^v0.3 to ^v0.4 (v0.3.2 => v0.4.0), which pulls in squizlabs/php_codesniffer 3.13.6. That PHPCS release warns about the comma-separated string syntax for array properties, deprecated since 3.3.0 and removed in 4.0, which our ruleset used for the TypeNameMatchesFileName rootNamespaces property. Rewrite it using <element> nodes. No source changes were needed — the v0.4 ruleset flags nothing in src/ or tests/. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 96.94% 96.94%
Complexity 308 308
=========================================
Files 25 25
Lines 983 983
=========================================
Hits 953 953
Misses 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
contributte/qafrom^v0.3to^v0.4(v0.3.2 => v0.4.0).Transitive updates pulled in:
squizlabs/php_codesniffer3.13.5 => 3.13.6phpstan/phpdoc-parser2.3.2 => 2.3.3Ruleset fix
The newer PHPCS warns on our own
ruleset.xml:Rewritten using
<element key="..." value="..."/>nodes. The sniff still applies tosrc/andtests/as before, and the warning is gone.Notes
No source changes were needed — the v0.4 ruleset flags nothing in
src/ortests/.v0.5 exists only as
0.5.x-dev, so^v0.4is the current stable ceiling.Verification
Run locally on PHP 8.3.31:
make phpstan— no errors (level 7,src/)make cs— 64/64 files, no warningsmake tests— 148 tests, 225 assertions, all passing🤖 Generated with Claude Code